ドロップダウンの作成#14
Open
Taiga2022 wants to merge 1 commit intoteamdevD:feature-createDropdown-Taiga2022from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//タイトルは[(#issue番号)から始めて下さい]
目的
issue07からブランチを切る形で新しくこのブランチを作り、ドロップダウンを作成しました。
達成条件
html要素をphaserに読み込む形でdropdownを作成する。
実装の概要
main.tsにdomを使うための設定をするために変更を加えました。dropdownはindex.ts内にcreateDropdown関数を作成しました。dropdownのスタイリングについてはひとまずindex.htmlにbulmaのcdnを配置してそれを使いました。
レビューして欲しいところ
見づらいコードがあればレビューしてほしいです。
保留, 悩んでいる所
時間があればボタンのほうも同じ実装にしたほうがいいかも